Announcement New JustUo Test Shard up and running

Discussion in 'News and Announcements' started by zerodowned, Dec 21, 2015.

  1. HawkEye

    HawkEye Super Contributor

    Okay fixed the bad graphics in ec with phase 4


    zerodowned I need to beable to get this files to u bud just some changes I made will fix it all
    Ill explain

    first you need to go into packets.cs

    find this code

    Code:
        public enum GraphicData : byte
        {
            TileData = 0x0,
            BodyData = 0x1,
            MultiData = 0x2
        }
    
        public sealed class WorldItemHS : Packet
        {
            public WorldItemHS(Item item)
                : base(0xF3, 26)
            {
                int itemId = item.ItemID;
    
                m_Stream.Write((short)1);
                m_Stream.Write((byte)item.GraphicData);
    
                m_Stream.Write((uint)item.Serial.Value);
                m_Stream.Write((short)itemId);
    
                m_Stream.Write((byte)item.Direction);
    
                m_Stream.Write((short)item.Amount);
                m_Stream.Write((short)item.Amount);
    
                Point3D loc = item.Location;
    
                m_Stream.Write((short)loc.X);
                m_Stream.Write((short)loc.Y);
                m_Stream.Write((sbyte)loc.Z);
    
                m_Stream.Write((byte)item.Light);
    
                m_Stream.Write((ushort)item.Hue);
                m_Stream.Write((byte)item.GetPacketFlags());
    
                m_Stream.Write((short)0x0); // 0 for new item, 1 for update
            }
        }
    and commit it out

    uncommit this code that is under that.

    Code:
        public sealed class WorldItemHS : Packet
        {
            public WorldItemHS(Item item)
                : base(0xF3, 26)
            {
                m_Stream.Write((short)0x1);
    
                int itemID = item.ItemID;
    
                if (item is BaseMulti)
                {
                    m_Stream.Write((byte)0x02);
    
                    m_Stream.Write(item.Serial);
    
                    itemID &= 0x3FFF;
    
                    m_Stream.Write((ushort)itemID);
    
                    m_Stream.Write((byte)0);
                }
                else
                {
                    m_Stream.Write((byte)0x00);
    
                    m_Stream.Write(item.Serial);
    
                    itemID &= 0xFFFF;
    
                    m_Stream.Write((ushort)itemID);
    
                    m_Stream.Write((byte)0);
                }
    
                int amount = item.Amount;
                m_Stream.Write((short)amount);
                m_Stream.Write((short)amount);
    
                Point3D loc = item.Location;
                int x = loc.m_X & 0x7FFF;
                int y = loc.m_Y & 0x3FFF;
                m_Stream.Write((short)x);
                m_Stream.Write((short)y);
                m_Stream.Write((sbyte)loc.m_Z);
    
                m_Stream.Write((byte)item.Light);
                m_Stream.Write((short)item.Hue);
                m_Stream.Write((byte)item.GetPacketFlags());
    
                m_Stream.Write((short)0x00); // ??
            }
        }

    then save and go to items.cs

    find this code
    Code:
            public void SendInfoTo(NetState state)
            {
                SendInfoTo(state, ObjectPropertyList.Enabled && GraphicData == GraphicData.TileData);
            }
    
            public virtual void SendInfoTo(NetState state, bool sendOplPacket)
            {
                state.Send(GetWorldPacketFor(state));
    
                if (sendOplPacket)
                {
                    state.Send(OPLPacket);
                }
            }
    
            public virtual GraphicData GraphicData { get { return GraphicData.TileData; } }
    commit it all out

    then add this code

    Code:
            public void SendInfoTo(NetState state)
            {
                SendInfoTo(state, ObjectPropertyList.Enabled);
            }
    
            public virtual void SendInfoTo(NetState state, bool sendOplPacket)
            {
                state.Send(GetWorldPacketFor(state));
    
                if (sendOplPacket)
                {
                    state.Send(OPLPacket);
                }
            }
    now save and go to basemulti.cs
    find this code
    Code:
    public override GraphicData GraphicData { get { return GraphicData.MultiData; } }
    commit it out and save

    now recompile core

    update tc with new core

    all bad and funky graphics will be fixed..

    sorry about that every one. need to test my own code more.
     
  2. Kyn

    Kyn Distinguished Member JustUO Developer

    You should just release pre-compiled versions as you go. :) Also you mean "comment" out :D
     
  3. HawkEye

    HawkEye Super Contributor

    well zerodowned will add this to his repo and update tc.
     
  4. Kyn

    Kyn Distinguished Member JustUO Developer

    Fair enough. :) thanks for the hard work.
     
  5. HawkEye

    HawkEye Super Contributor

    np I was tearing all the code apart to find the bug I almost thought maybe was something else changed in the core so I even traced down point3d and it looked fine..

    so again was just something I did in packet changes and I should of tested it.
     
  6. Kyn

    Kyn Distinguished Member JustUO Developer

    Not sure if this has been reported but it's basically game breaking.. I was running around on the test center and I went to train healing (and a variety of other skills) and when I attempted to drop gold onto the NPC to train me for healing my gold was accepted but my remaining gold stack then became invisible inside my inventory. When I switch my inventory over to list mode I can see the gold but when its in grid view its invisible.

    I'm wondering if this has to do with the backpack not refreshing properly when the gold amount/stack packet is sent. could also be an issue with the EC code that was added to container.cs but I wont have time to poke around more until I get home.

    Anyway if you know of a fix or have any ideas please let me know. I'd love to fix this ASAP on my test EC shard.

    Item Stacks (gold, bandages, etc) are disappearing when separated into multiple stacks.
     
    Last edited: Jan 3, 2016
  7. zerodowned

    zerodowned Administrator Moderator JustUO Developer Gold Star Member Et Cetera, Et Cetera

    updated to repo, will test it out.
    thanks again HawkEye
     
  8. zerodowned

    zerodowned Administrator Moderator JustUO Developer Gold Star Member Et Cetera, Et Cetera

    tested and can confirm it fixed the issue with lamp post and moongate
     
  9. zerodowned

    zerodowned Administrator Moderator JustUO Developer Gold Star Member Et Cetera, Et Cetera

    Found a bug that I don't believe has been reported.
    Also, I'm not sure if it has anything to do with JustUo or if it's just a EC bug.

    When you click on an item, the target info shows Health for the item

    upload_2016-1-6_8-28-50.png
     
  10. MajinCry

    MajinCry Distinguished Member

    Found a couple bugs meself.

    The first being that using accented characters (áéúíó) during character creation causes the character, once created, to have the name "Generic Player".

    The second being that the moongate teleport effect does not center on the player character; it is played off-screen at the bottom-right of the game window.
     
  11. HawkEye

    HawkEye Super Contributor

    healthbar on items seems to be a ec thing i see that on live shards.

    creating a char with those letters in justuo will make your char name be generic player it has a check for thos ein the code.

    I will look into the moongate effect.

    thank you both for testing makes it easy for me to track them nasty bugs down.

    Also i think i have the vendor train gold bug fixed if so ill post it for you zero
     
  12. Yvan

    Yvan Renowned Member

    Hi all and i am very happy there is a Enhenced Client version that is worked on.

    Me and my wife are playing on the EA game but we're looking to create our own shard just for us if we can get a hand on the Enhanced Client Repo. We tried the Classic but its really too bad to let us leave UO.

    Is there a way we can get a hand on the EC Repo, open our server and report bugs here yet ?
     

Share This Page